Re: LLVM jit and matview
| От | Tom Lane |
|---|---|
| Тема | Re: LLVM jit and matview |
| Дата | |
| Msg-id | 14398.1532559591@sss.pgh.pa.us обсуждение исходный текст |
| Ответ на | Re: LLVM jit and matview (Andres Freund <andres@anarazel.de>) |
| Ответы |
Re: LLVM jit and matview
Re: LLVM jit and matview |
| Список | pgsql-hackers |
Andres Freund <andres@anarazel.de> writes:
> On 2018-07-25 18:11:13 -0400, Alvaro Herrera wrote:
>> But what would be the advantage of avoiding the context release inside
>> FreeExecutorState? It seems pretty appropriate to me to do it there.
>> You could argue that the JIT context is definitely part of the estate
>> being freed. Just amend the comment, no?
> I agree it's right to do it there. I think I'm more questioning whether
> there's even a need to adapt the comment, given it's really a local
> memory resource. But I guess I'll just add a 'and ...' after
> "ExprContexts within the EState".
+1. Clarity is good.
regards, tom lane
В списке pgsql-hackers по дате отправления: