Re: SSL SNI

Jacob Champion <pchampion@vmware.com> writes:
> It looks like this code needs some guards for a NULL conn->pghost. For example when running
>     psql 'dbname=postgres sslmode=require hostaddr=127.0.0.1'
> with no PGHOST in the environment, psql is currently segfaulting for
> me.

Duplicated here:

Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007f3adec47ec3 in __strspn_sse42 () from /lib64/libc.so.6
(gdb) bt
#0  0x00007f3adec47ec3 in __strspn_sse42 () from /lib64/libc.so.6
#1  0x00007f3adf6b7026 in initialize_SSL (conn=0xed4160)
    at fe-secure-openssl.c:1090
#2  0x00007f3adf6b8755 in pgtls_open_client (conn=conn@entry=0xed4160)
    at fe-secure-openssl.c:132
#3  0x00007f3adf6b3955 in pqsecure_open_client (conn=conn@entry=0xed4160)
    at fe-secure.c:180
#4  0x00007f3adf6a4808 in PQconnectPoll (conn=conn@entry=0xed4160)
    at fe-connect.c:3102
#5  0x00007f3adf6a5b31 in connectDBComplete (conn=conn@entry=0xed4160)
    at fe-connect.c:2219
#6  0x00007f3adf6a8968 in PQconnectdbParams (keywords=keywords@entry=0xed40c0,
    values=values@entry=0xed4110, expand_dbname=expand_dbname@entry=1)
    at fe-connect.c:669
#7  0x0000000000404db2 in main (argc=<optimized out>, argv=0x7ffc58477208)
    at startup.c:266

You don't seem to need the "sslmode=require" either, just an
SSL-enabled server.

            regards, tom lane