Re: ToDo: show size of partitioned table

On 2019/03/14 2:11, Pavel Stehule wrote:
> st 13. 3. 2019 v 8:02 odesílatel Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
> napsal:
>> Not a native speaker either, but I like Justin's changes.  Although I
>> noticed that he missed changing one sentence to look like other similar
>> sentences.
>>
>> What Justin did:
>>
>> -        indexes) and associated description are also displayed.
>> +        indexes) is displayed, as is the relation's description.
>>          </para>
>>
>> What I think he meant to do:
>>
>> -        indexes) and associated description are also displayed.
>> +        indexes) is also displayed, along with the associated description.
>>          </para>
>>
>>
>>> I am not sure if we use labels in form "some: detail" somewhere.
>>
>> I haven't seen column names like that either.  How about:
>>
>> -                              gettext_noop("Direct partitions size"));
>> +                              gettext_noop("Leaf partition size"));
>>
>> -                              gettext_noop("Total partitions size"));
>> +                              gettext_noop("Total size"));
>>
>> -                              gettext_noop("Partitions size"));
>> +                              gettext_noop("Total size"));
>>
> 
> +1
> 
> Pavel
> 
> 
>> I've attached v11 of the patch, which merges most of Justin's changes and
>> some of my own on top -- documentation and partition size column names.

Maybe, we should set this ready for committer then?

Thanks,
Amit