On Tue, 2013-01-15 at 00:29 +0100, Andres Freund wrote:
> Independently from this patch, should we add -Wtype-limits to the
> default parameters?
I think we have had a discussion along this line before. I am against
fixing warnings from this option, because those changes would hide
errors if a variable's type changed from signed to unsigned or vice
versa, which could happen because of refactoring or it might be
dependent on system headers.
FWIW, clang has the same warning on by default. There, it's called
-Wtautological-compare.
I'm less concerned about -Wempty-body, but I can't see the practical use
either way.