Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)

Jeff Davis <pgsql@j-davis.com> writes:
> On Tue, 2011-07-05 at 13:56 -0400, Tom Lane wrote:
>> Yeah, I had been thinking along the same lines.  It will require
>> duplicating the search loop, which is a bit annoying, but perhaps that
>> could be factored out as a subroutine.

> Patch attached. The logic in predtest.c was a little more complex, and I
> don't think we have a lot of test coverage in this area (and I didn't
> see an easy way to add many tests), so this will need some review.

Actually, I'd just been working on this myself.  I think the cleanest
solution will be to get rid of the duplicative logic by making
predtest.c use get_op_btree_interpretation().  That will require
changing get_op_btree_interpretation() so it can return amoplefttype
and amoprighttype too, but given the small number of callers, an API
change for it doesn't seem like a problem.

            regards, tom lane