foreign key locks
От | Alvaro Herrera |
---|---|
Тема | foreign key locks |
Дата | |
Msg-id | 1339690386-sup-8927@alvh.no-ip.org обсуждение исходный текст |
Ответы |
Re: foreign key locks
|
Список | pgsql-hackers |
Hi, This is v12 of the foreign key locks patch. I gave a talk about this patch at PGCon: http://www.pgcon.org/2012/schedule/events/483.en.html There is an article there that explains this patch. I described the original goal of this in the thread starting here: http://archives.postgresql.org/message-id/1290721684-sup-3951@alvh.no-ip.org The patch itself was first submitted here: http://archives.postgresql.org/message-id/1320343602-sup-2290@alvh.no-ip.org There were many problems that we had to shake off during the 9.2 development cycle; this new version covers most of them. There is a github clone here: http://github.com/alvherre/postgres branch fklocks If you see the "compare" view, changes in this submission that weren't present in v11 start with commit 19dc85f1, here: https://github.com/alvherre/postgres/compare/master...fklocks I know of one significant issue left, possible cause of nasty bugs, which is the way this patch interacts with EvalPlanQual. I mentioned erroneously in my PGcon talk that the way we handle this is by shutting off EPQ recursion -- this was wrong. What I did was shut off heap_lock_tuple from following the update chain, letting it walk only in the cases where it comes from high-level callers. Others such as EPQ, which do their own update-chain walking, do not request locks to follow update. I believe this is correct. This was changed in this commit: https://github.com/alvherre/postgres/commit/e00e6827c55128ed737172a6dd35c581d437f969 There is also a matter of a performance regression we measured in stock pgbench. I have profiled this to come from GetMultiXactMembers and AFAICS the way to fix it is to improve multixact.c's cache of old multis. Right now we ditch the cache at end of transaction, which was already considered wrong in comments in the code but never fixed. I am going to make the cache entries live until the oldest Xid in each multi is below its visibility horizon (so RecentXmin for multis that only contain locks, and something like FreezeLimit for multis that contain updates). I apologize for the size of this patch. I am not really sure that there are pieces to split out for separate review. -- Álvaro Herrera <alvherre@alvh.no-ip.org>
Вложения
В списке pgsql-hackers по дате отправления: