Re: When do we lose column names?

Excerpts from Andrew Dunstan's message of jue feb 09 16:38:27 -0300 2012:

> OK, the one place that needs to be fixed to avoid the crash caused by
> the json regression tests with the original patch is in
>
>     src/backend/parser/parse_expr.c:transformRowExpr().
>
> Other candidates I have found that don't set colnames and should
> probably use dummy names are:
>
>   * src/backend/parser/gram.y (row: production)
>   * src/backend/optimizer/prep/prepunion.c:adjust_appendrel_attrs_mutator()
>   * src/backend/optimizer/util/var.c:flatten_join_alias_vars_mutator()
>
>
> Given a function:
>
>     extern List *makeDummyColnames(List * args);
>
>
> what's the best place to put it? I couldn't see a terribly obvious place
> in the source.

parse_relation.c?

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support