Re: Dry-run mode for pg_archivecleanup

Excerpts from Josh Kupershmidt's message of vie ene 27 19:43:51 -0300 2012:
> On Fri, Jan 27, 2012 at 9:47 AM, Robert Haas <robertmhaas@gmail.com> wrote:

> > This email thread seems to have trailed off without reaching a
> > conclusion.  The patch is marked as Waiting on Author in the
> > CommitFest application, but I'm not sure that's accurate.  Can we try
> > to nail this down?
>
> Perhaps my last email was a bit wordy. The only real change I am
> suggesting for Gabriele's patch is that the message printed to stderr
> when debug + dryrun are activated be changed to "would remove file
> ..." from "removing file", i.e around line 124:
>
>                 if (debug)
>                     fprintf(stderr, "%s: %s file \"%s\"\n",
>                             progname, (dryrun ? "would remove" : "removing"),
>                             WALFilePath);
>
> Other than that little quibble, I thought the patch was fine.

If you do that, please make sure you use two complete separate strings
instead of building one from spare parts.  This bit is missing the _()
stuff though.

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support