Re: WIP: explain analyze with 'rows' but not timing
| От | Alvaro Herrera |
|---|---|
| Тема | Re: WIP: explain analyze with 'rows' but not timing |
| Дата | |
| Msg-id | 1324658101-sup-4971@alvh.no-ip.org обсуждение исходный текст |
| Ответ на | Re: WIP: explain analyze with 'rows' but not timing (Tomas Vondra <tv@fuzzy.cz>) |
| Список | pgsql-hackers |
Excerpts from Tomas Vondra's message of vie dic 23 11:45:40 -0300 2011: > One thing I'm wondering about is that the InstrumentOptions are not > exclusive - INSTRUMENT_TIMER means 'collect timing and row counts' while > INSTRUMENT_ROWS means 'collect row counts'. Wouldn't it be better to > redefine the INSTRUMENT_TIMER so that it collects just timing info. I.e. > to get the current behaviour, you'd have to do this > > instrument_options |= (INSTRUMENT_TIMER | INSTRUMENT_ROWS) > > It's quite trivial change in explain.c, the problem I have with that is > that it might break extensions. No, maybe add INSTRUMENT_TIMER_ONLY and then define INSTRUMENT_TIMER as setting both. That way you don't break compatibility. -- Álvaro Herrera <alvherre@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support
В списке pgsql-hackers по дате отправления: