Re: new compiler warnings

On tis, 2011-10-18 at 09:32 -0400, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
> > It is a pity we can't just tell the compiler to turn off the warning in 
> > a particular case.
> 
> I haven't tested, but won't an explicit cast to void silence the
> warning?
> 
>     (void) fwrite(...);

No, tried that already.  You could try
   rc = write(...);   (void) rc;

> There are places, notably the calls in elog.c, where ignoring write
> failures is the right thing.  I think that what Kevin was on about
> was something else entirely, namely whether we need to retry writes
> to disk.  I would hope that we're not simply not bothering to check
> in any cases where it matters.

No, I believe we are OK everywhere else.  We are only ignoring the
result in cases where we are trying to report errors in the first place.