Re: gcc 4.6 warnings in HEAD?

On ons, 2011-08-10 at 12:37 -0400, Alvaro Herrera wrote:
> I'm seeing a bunch of warnings I don't remember seeing before in the
> master branch:
> 
> /pgsql/source/HEAD/src/backend/executor/execQual.c: In function
> 'GetAttributeByNum':
> /pgsql/source/HEAD/src/backend/executor/execQual.c:1104:11: warning: the comparison will always evaluate as 'true'
forthe address of 'tmptup' will never be NULL [-Waddress] 
 

Yes, these are new with gcc 4.6.  I have filed a bug about them:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48778

All the other new warnings introduced by gcc 4.6 should be cleaned up by
now in the 9.2 branch.  (There are more warnings in 9.1 whose fixes I
did not backpatch.)  I am personally using

make COPT="-Werror -Wno-error=address"

to build PostgreSQL for the time being.