Re: make check in contrib

On mån, 2011-04-25 at 13:12 -0400, Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > On mån, 2011-04-25 at 11:22 -0400, Tom Lane wrote:
> >> The proposed patch is to fix it, not remove it.  Surely that's more
> >> useful than a no-op target.
> 
> > The proposed patch will support make check for contrib modules, but not
> > for external users of pgxs.
> 
> So what will happen if an external user tries it?  What happens now?

Now:

$ make check
'make check' is not supported.
Do 'make install', then 'make installcheck' instead.
make: *** [check] Error 1

If we removed that, then it would be:

make: Nothing to be done for `check'.
[exit 0]

Hmm, I'm slightly surprised by the latter behavior, but it's the case
that since "check" is a global phony target, if you don't provide
commands for it, it will just do nothing and succeed.

Since some people didn't like removing the hint about "installcheck",
I'd suggest just removing the "exit 1", which should then be pretty
consistent overall.