Re: Review: Fix snapshot taking inconsistencies

Excerpts from Tom Lane's message of mar oct 12 20:49:28 -0300 2010:
> Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi> writes:
> > On 2010-10-13 2:10 AM +0300, Tom Lane wrote:
> >> BTW, this patch seems to be also the time to remove the AtStart_Cache()
> >> call in CommandCounterIncrement, as foreseen in the comment there.
> 
> > Frankly, I have no idea what to do about this.
> 
> Just delete the call.  The only reason I didn't remove it in 2007 is
> I was afraid to risk changing things in late beta; but that's not the
> situation now.

I just applied just this change and ran the regression tests; it works
fine.  I didn't do anything else though, like the cache-clobber-always
flag, etc.  If no one objects I will push this patch to see what the
buildfarm has to say about it.

diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c
index b02db9e..d2e2e11 100644
--- a/src/backend/access/transam/xact.c
+++ b/src/backend/access/transam/xact.c
@@ -729,17 +729,6 @@ CommandCounterIncrement(void)        */       AtCCI_LocalCache();   }
-
-   /*
-    * Make any other backends' catalog changes visible to me.
-    *
-    * XXX this is probably in the wrong place: CommandCounterIncrement should
-    * be purely a local operation, most likely.  However fooling with this
-    * will affect asynchronous cross-backend interactions, which doesn't seem
-    * like a wise thing to do in late beta, so save improving this for
-    * another day - tgl 2007-11-30
-    */
-   AtStart_Cache();}/*


-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support