Re: pgsql: Add pg_alterckey utility to change the cluster key

Bruce Momjian <bruce@momjian.us> writes:
> On Sat, Dec 26, 2020 at 06:16:37PM +0900, Michael Paquier wrote:
>> The CF bot at http://cfbot.cputube.org/ includes tests on Windows, so
>> those problems would have been detected beforehand.  Did you look at
>> these?  If this cannot be fixed, could it be possible to revert
>> please?  It looks rather clear that this has not been tested across
>> multiple platforms, and the absence of tests to allow the buildfarm to
>> stress this code does not really help either in gaining confidence
>> that this is stable.

> I have been working on this patch for almost two months, and wanted to
> try to get it into the tree near Christmas as sort of a Christmas
> present to the community.

It's not much of a "Christmas present" to have to spend part of the
holiday fixing somebody else's obviously under-baked commits.

I think you should revert *all* of this and not come back until
(a) you have some test cases and (b) somebody besides you has read
the entire patch.  There are way too many beginner-level errors in
what you've pushed so far.  And that's not even counting the question
of whether the design is right to begin with, which somebody already
expressed doubts about.

            regards, tom lane