Re: Indent authentication overloading

Magnus Hagander <magnus@hagander.net> writes:
> Here's an updated patch that removes this log message, and adds a few
> lines to initdb to create a combination of ident/peer rows. And
> finally, adds docs.

> Comments?

As near as I can tell (I hate reading u-style diffs) you've documented
the ident and peer keywords as being mutually exclusive, ie, the docs
say that the correct keyword for the connection type *must* be used in
pg_hba.conf.  Which is not how the code behaves, and shouldn't be how
the code behaves, for backwards-compatibility reasons.  The docs need
to state the truth, namely that "ident" is still allowed as a synonym
for "peer" on local connections.  Otherwise people will get confused
as to why their pg_hba files still work.

The code changes look sane in a quick scan, though I didn't read them
in detail.
        regards, tom lane