Re: split rm_name and rm_desc out of rmgr.c
От | Tom Lane |
---|---|
Тема | Re: split rm_name and rm_desc out of rmgr.c |
Дата | |
Msg-id | 12600.1360107522@sss.pgh.pa.us обсуждение исходный текст |
Ответ на | Re: split rm_name and rm_desc out of rmgr.c (Alvaro Herrera <alvherre@2ndquadrant.com>) |
Список | pgsql-hackers |
Alvaro Herrera <alvherre@2ndquadrant.com> writes: > Patch attached. Seems like a couple of the comments could use updates: > * Note: RM_MAX_ID could be as much as 255 without breaking the XLOG file > * format, but we keep it small to minimize the size of RmgrTable[]. This is no longer particularly sensible, since we're no longer making any provision for wasted RmgrIds. Perhaps rephrase as "RM_MAX_ID must fit in RmgrId; widening that type will affect the XLOG file format." > + * List of resource manager entries. Note that order of entries defines the > + * numerical values of each rmgr's ID. > + * > + * Changes to this list possibly need a XLOG_PAGE_MAGIC bump. Probably also a good idea to state explicitly that new entries should go at the end to avoid moving the IDs of existing entries. Works for me otherwise. regards, tom lane
В списке pgsql-hackers по дате отправления: