Re: Could regexp_matches be immutable?

On Tue, 2009-10-20 at 20:48 -0400, Tom Lane wrote:
> So I went to see about making the changes to remove regex_flavor, and
> was astonished to find that all the regex-related functions are already
> marked immutable, and AFAICS always have been.  This is clearly wrong,
> and we would have to fix it if we weren't about to remove the GUC.
> (In principle we should advise people to change the markings in existing
> databases, but given the lack of complaints it's probably not worth the
> trouble --- I doubt many applications change regex_flavor on the fly.)

Are you sure this wasn't intentional, because it breaks performance and
we doubted that many applications would change regex_flavor on the fly?