Re: [PATCH][PROPOSAL] Add enum releation option type

Поиск
Список
Период
Сортировка
От Nikolay Shaplov
Тема Re: [PATCH][PROPOSAL] Add enum releation option type
Дата
Msg-id 12291633.PFnvXaAOpE@x200m
обсуждение исходный текст
Ответ на Re: [PATCH][PROPOSAL] Add enum releation option type  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Ответы Re: [PATCH][PROPOSAL] Add enum releation option type  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Re: [PATCH][PROPOSAL] Add enum releation option type  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
В письме от 1 марта 2018 14:47:35 пользователь Alvaro Herrera написал:

> I see you lost the Oxford comma:
>
> -DETAIL:  Valid values are "on", "off", and "auto".
> +DETAIL:  Valid values are "auto", "on" and "off".
>
> Please put these back.
Actually that's me who have lost it. The code with  oxford comma would be a
bit more complicated. We should put such coma when we have 3+ items and do not
put it when we have 2.

Does it worth it?

As I've read oxford using of comma is not mandatory and used to avoid
ambiguity.
"XXX, YYY and ZZZ" can be read as "XXX, YYY, ZZZ" or as "XXX, (YYY and ZZZ)".
oxford comma is used to make sure that YYY and ZZZ are separate items of the
list, not an expression inside one item.

But here we hardly have such ambiguity.

So I'll ask again, do you really think it worth it?


--
Do code for fun.
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Petr Jelinek
Дата:
Сообщение: Re: public schema default ACL
Следующее
От: Stephen Frost
Дата:
Сообщение: Re: public schema default ACL