Re: Explain XML patch v2

On Sat, 2008-07-05 at 16:00 +0100, Dave Page wrote:
> On Sat, Jul 5, 2008 at 10:41 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
> >
> > It can be optional since plugins can add parameters also.
>
> GUCs I assume you mean, not grammar. Unless I'm misreading the code
> though, if the plugin is there it will always run instead of the
> regular explain code, so presumabiy that's optional as in XML or
> nothing, not XML or standard output.

You can easily make it switchable between XML and normal.

> > It wouldn't take long to make up a plugin for 8.3 once this patch has
> > been committed to core for 8.4, so if you're saying you'd definitely
> > like it in core then I'm OK with that.
>
> If i's always there it's definitely more useful to pgAdmin, and
> doesn't require that we instruct users to install more server side
> plugin code to use the features they want.

As I said, I'm OK with that.

--
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support