Re: [HACKERS] odd output in restore mode

On Mon, 2008-06-30 at 19:29 -0400, Andrew Dunstan wrote:
>
> Bruce Momjian wrote:
> > Dave Page wrote:
> >
> >> On Sun, May 18, 2008 at 1:38 PM, Andrew Dunstan <andrew@dunslane.net> wrote:
> >>
> >>> I don't know how you tested,
> >>>
> >> Copy a large file across a relatively slow network, and check the size
> >> on the destination drive before it finishes.
> >>
> >>
> >>> but could you please repeat the test with
> >>> GnuWin32's cp.exe? If it doesn't preallocate the space then I think our way
> >>> forward is reasonably clear:
> >>>
> >> It does not pre-allocate.
> >>
> >>
> >>> . we recommend its use for Windows archive_command settings
> >>> . we provide the delay kluge as switchable behaviour on Windows instead of
> >>> having it always on.
> >>>
> >> Sounds reasonable to me.
> >>
> >
> > Are there any changes we need to make here?
> >
> >
>
> Yes. Simon has promised a patch to do the above.

Patch implements

* recommendation to use GnuWin32 cp on Windows
* provide "holdtime" delay, default 0 (on all platforms)
* default stays same on Windows="copy" to ensure people upgrading don't
get stung

Patch should be backpatched to 8.3, plus to CVS HEAD.

We should recommend in next 8.3 release notes that people use "-p" or
"-l" rather than just letting it default.

Will add permalink to Wiki when patch appears in archives.

--
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support