Re: Split xlog.c

On 14/02/2022 11:36, Heikki Linnakangas wrote:
> On 27/01/2022 08:34, Michael Paquier wrote:
>> On Tue, Jan 25, 2022 at 12:12:40PM +0200, Heikki Linnakangas wrote:
>>> In last round of review, I spotted one bug: I had mixed up the meaning of
>>> EndOfLogTLI. It is the TLI in the *filename* of the WAL segment that we read
>>> the last record from, which can be different from the TLI that the last
>>> record is actually on. All existing tests were passing with that bug, so I
>>> added a test case to cover that case.
>>
>> FYI, this overlaps with a different patch sent recently, as of this
>> thread:
>> https://www.postgresql.org/message-id/CAAJ_b94Vjt5cXGza_1MkjLQWciNdEemsmiWuQj0d=M7JfjAa1g@mail.gmail.com
> 
> Thanks, I pushed this new test case now.
> 
> With the rest of the patches, I'm seeing a mysterious failure in cirrus
> CI, on macOS on the 027_stream_regress.pl test. It doesn't make much
> sense to me, but I'm investigating that now.

Fixed that, and pushed. Thanks everyone for the reviews!

- Heikki