Re: Changing types of block and chunk sizes in memory contexts
| От | Tom Lane |
|---|---|
| Тема | Re: Changing types of block and chunk sizes in memory contexts |
| Дата | |
| Msg-id | 1139140.1687949983@sss.pgh.pa.us обсуждение исходный текст |
| Ответ на | Re: Changing types of block and chunk sizes in memory contexts (David Rowley <dgrowleyml@gmail.com>) |
| Ответы |
Re: Changing types of block and chunk sizes in memory contexts
Re: Changing types of block and chunk sizes in memory contexts |
| Список | pgsql-hackers |
David Rowley <dgrowleyml@gmail.com> writes:
> Perhaps it's ok to leave the context creation functions with Size
> typed parameters and then just Assert the passed-in sizes are not
> larger than 1GB within the context creation function.
Yes, I'm strongly opposed to not using Size/size_t in the mmgr APIs.
If we go that road, we're going to have a problem when someone
inevitably wants to pass a larger-than-GB value for some context
type.
What happens in semi-private structs is a different matter, although
I'm a little dubious that shaving a couple of bytes from context
headers is a useful activity. The self-documentation argument
still has some force there, so I agree with Peter that some positive
benefit has to be shown.
regards, tom lane
В списке pgsql-hackers по дате отправления: