Re: Client build of MSVC6+ patch
От | Tom Lane |
---|---|
Тема | Re: Client build of MSVC6+ patch |
Дата | |
Msg-id | 11154.1151466324@sss.pgh.pa.us обсуждение исходный текст |
Ответ на | Re: Client build of MSVC6+ patch ("Hiroshi Saito" <z-saito@guitar.ocn.ne.jp>) |
Ответы |
Re: Client build of MSVC6+ patch
|
Список | pgsql-patches |
"Hiroshi Saito" <z-saito@guitar.ocn.ne.jp> writes: >> Why do we need to reorder the fields in the struct? > Eh? Even my FreeBSD used well shows a structure object. The standard lists the fields in the other order: http://www.opengroup.org/onlinepubs/009695399/basedefs/netdb.h.html Even though the standard doesn't say that that has to be the physical order, every other platform besides Windows does it that way. The patch as given is unacceptable because it *will* break other platforms (mine for instance ;-)). If it has to be this way for Windows then we need some sort of platform-specific #ifdef. Considering that the code works as-is on several sorts of Windows builds, we probably need something even more specific than that, like #if MSVC-before-version-XX. regards, tom lane
В списке pgsql-patches по дате отправления: