Bad macro in pg_wchar.h?

Поиск
Список
Период
Сортировка
От Oliver Elphick
Тема Bad macro in pg_wchar.h?
Дата
Msg-id 1053599987.25709.2142.camel@linda.lfix.co.uk
обсуждение исходный текст
Ответы Re: Bad macro in pg_wchar.h?  (Bruce Momjian <pgman@candle.pha.pa.us>)
Список pgsql-hackers
In src/include/mb/pg_wchar.h we have:

#define PG_ENCODING_BE_LAST PG_ISO_8859_8
#define PG_ENCODING_FE_LAST PG_WIN1256

but the last client encoding in the enum list is actually PG_GB18030 and
it seems that 

#define PG_ENCODING_IS_CLIEN_ONLY(_enc) \               (((_enc) > PG_ENCODING_BE_LAST && (_enc) <=
PG_ENCODING_FE_LAST)

can never be true.

I think the define should read
#define PG_ENCODING_FE_LAST PG_GB18030

On the other hand, perhaps no-one cares, because
PG_ENCODING_IS_CLIEN_ONLY is never used.

-- 
Oliver Elphick                                Oliver.Elphick@lfix.co.uk
Isle of Wight, UK                             http://www.lfix.co.uk/oliver
GPG: 1024D/3E1D0C1C: CA12 09E0 E8D5 8870 5839  932A 614D 4C34 3E1D 0C1C
========================================   "O come, let us worship and bow down; let us kneel     before the LORD our
maker."         Psalms 95:6 
 



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Steve King
Дата:
Сообщение: Is postgres 7.2.1 safe if there is a power fail.
Следующее
От: Tom Lane
Дата:
Сообщение: Re: $PostgreSQL$ for revision info