On 20.01.24 03:33, vignesh C wrote:
> On Fri, 25 Aug 2023 at 01:23, Tristan Partin <tristan@neon.tech> wrote:
>>
>> On Thu Aug 24, 2023 at 2:30 PM CDT, Tom Lane wrote:
>>> "Tristan Partin" <tristan@neon.tech> writes:
>>>> On Wed Aug 23, 2023 at 2:24 PM CDT, Peter Eisentraut wrote:
>>>>> Somewhere at PGCon, I forgot exactly where, maybe in the same meeting
>>>>> where we talked about getting rid of distprep, we talked about that the
>>>>> documentation builds are not reproducible (in the sense of
>>>>> https://reproducible-builds.org/). This is easily fixable,
>>>
>>>> Is there anything I am missing? Is Postgres relying on releases older
>>>> than snapshot-2018-12-07-01? If so, is it possible to up the minimum
>>>> version?
>>>
>>> AFAICT the "latest stable release" of docbook-xsl is still 1.79.2,
>>> which seems to have been released in 2017, so it's unsurprising that
>>> it's missing this fix.
>>>
>>> It's kind of hard to argue that developers (much less distro packagers)
>>> should install unsupported snapshot releases in order to build our docs.
>>> Having said that, maybe we should check whether this patch is compatible
>>> with those snapshot releases, just in case somebody is using one.
>>
>> I agree with you. Thanks for the pointer.
>
> I'm seeing that there has been no activity in this thread for nearly 5
> months, I'm planning to close this in the current commitfest unless
> someone is planning to take it forward.
I think there was general agreement with what this patch is doing, but I
guess it's too boring to actually review the patch in detail. Let's
say, if there are no objections, I'll go ahead and commit it.