Re: patch for src/backend/main/main.c
От | Michael C. Thornburgh |
---|---|
Тема | Re: patch for src/backend/main/main.c |
Дата | |
Msg-id | 10101231731.aa10461@aldebaran.armory.com обсуждение исходный текст |
Ответ на | patch for src/backend/main/main.c ("Michael C. Thornburgh" <zenomt@armory.com>) |
Ответы |
Re: Re: patch for src/backend/main/main.c
Re: Re: patch for src/backend/main/main.c |
Список | pgsql-patches |
that certainly works and is much cleaner, but strdup may not be as ubiquitous as malloc & strncpy. someone more versed in portability issues than i am should speak to that. -michael thornburgh > From: Tom Lane <tgl@sss.pgh.pa.us> > > "Michael C. Thornburgh" <zenomt@armory.com> writes: > > + len = strlen(pw->pw_name); > > + pw_name_persist = (char *) malloc(len+1); > > + if (pw_name_persist == (char *)NULL) > > + { > > + fprintf(stderr, "%s: can't malloc for username\n", argv[0]); > > + exit(1); > > + } > > + strncpy(pw_name_persist, pw->pw_name, len+1); > > This could be simplified to > pw_name_persist = strdup(pw->pw_name); > no? > > regards, tom lane
В списке pgsql-patches по дате отправления: