Re: Bug fix for psql's meta-command \ev

Поиск
Список
Период
Сортировка
От Ryoga Yoshida
Тема Re: Bug fix for psql's meta-command \ev
Дата
Msg-id 0b87efc5a628fe4f1144c2d6879894dc@oss.nttdata.com
обсуждение исходный текст
Ответ на Re: Bug fix for psql's meta-command \ev  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
On 2023-09-20 09:32, Michael Paquier wrote:
> Actually there was a bit more to it in the presence of \e, that could
> also get some unpredictible behaviors if some errors happen while
> editing a query, which is something unlikely, still leads to strange
> behaviors on failure injections.  I was considering first to move the
> reset in do_edit(), but also we have the case of \e[v|f] where the
> buffer has no edits so it felt a bit more natural to do that in the
> upper layer like in this patch.

Indeed, similar behaviours can happen with the \e. The patch you 
committed looks good to me. Thank you.

Ryoga Yoshida



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: XLog size reductions: Reduced XLog record header size for PG17
Следующее
От: Kyotaro Horiguchi
Дата:
Сообщение: Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows