Re: Warning is adjusted of pgbench.
От | Hiroshi Saito |
---|---|
Тема | Re: Warning is adjusted of pgbench. |
Дата | |
Msg-id | 0b7b01c80172$1aaa0a30$c601a8c0@HP22720319231 обсуждение исходный текст |
Ответ на | Warning is adjusted of pgbench. ("Hiroshi Saito" <z-saito@guitar.ocn.ne.jp>) |
Список | pgsql-patches |
Hi. From: "Tom Lane" <tgl@sss.pgh.pa.us> > Magnus Hagander <magnus@hagander.net> writes: >> On Tue, Aug 07, 2007 at 04:58:19PM +0900, Hiroshi Saito wrote: >>> pgbench.c: In function `main': >>> pgbench.c:1257: warning: implicit declaration of function `getopt' >>> >>> adjustment of some reference is required for this. > >> Why do you need to #undef EXEC_BACKEND, and is there a specific reason for >> removing the include of win32.h? > > I've applied the attached modified version of this patch; it keeps > win32.h in there (correctly re-marked as a system header). I think > the fundamental issue must be that Hiroshi's system sets HAVE_GETOPT and > HAVE_GETOPT_H. The former causes port.h to not supply a declaration > of getopt(), so we'd better include <getopt.h> to declare it. > > Together with the changes for FRONTEND applied a little bit ago, > I hope that this issue is fully resolved in CVS HEAD. Let me know if > there's still a problem. Yeah, I think that it felt it very refreshed.!:-) Though FRONTEND needs adjustment to consider carefully. Thanks. Regards, Hiroshi Saito
В списке pgsql-patches по дате отправления: