Re: Online checksums patch - once again

On 22/01/2021 14:21, Heikki Linnakangas wrote:
> On 22/01/2021 13:55, Heikki Linnakangas wrote:
>> I read through the latest patch,
>> v31-0001-Support-checksum-enable-disable-in-a-running-clu.patch. Some
>> comments below:
> 
> One more thing:
> 
> In SetRelationNumChecks(), you should use SearchSysCacheCopy1() to get a
> modifiable copy of the tuple. Otherwise you modify the tuple in the
> relcache as a side effect. Maybe that's harmless in this case, as the
> 'relhaschecksums' value in the relcache isn't used for anything, but
> let's be tidy.

Sorry, I meant SetRelHasChecksums. There is no SetRelationNumChecks 
function, I don't know where I got that from.

- Heikki