Re: PostgreSQL driver for Joomla review

On 20 Oct 2009, at 14:02, Thom Brown wrote:

> If anyone has a moment, could they review the PostgreSQL driver I
> wrote for Joomla's next major release?  The developers at Joomla have
> listened to the persistent noise created about only having MySQL as an
> option and are now accepting submissions for alternative database
> systems. (see
http://groups.google.com/group/joomla-dev-cms/browse_thread/thread/1382dc6f4af56278#msg_9b95648941ef6fa7
> for this development)
>
> My submission can be found at:
> http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=18384
>
> Things to watch out for a version-dependent features and clumsy
> implementations.


You miss a keyword in your query in renameTable; it should be " RENAME
TO ", not " TO ".

Wouldn't it be convenient to have an EXPLAIN ANALYSE version of explain
()? Maybe with a boolean parameter?

In insertObject() you have a query "SELECT $keyName AS 'id' FROM
$table'" - That line contains two syntax errors: 'id' (You probably
meant "id") and $table' (spurious trailing quote).

Regards,
Alban Hertroys

--
Screwing up is the best way to attach something to the ceiling.


!DSPAM:737,4addf36611682031315238!