Re: json(b)_to_tsvector with numeric values
От | Teodor Sigaev |
---|---|
Тема | Re: json(b)_to_tsvector with numeric values |
Дата | |
Msg-id | 064de98a-23e2-01f9-13c2-2f518aaa3089@sigaev.ru обсуждение исходный текст |
Ответ на | Re: json(b)_to_tsvector with numeric values (Dmitry Dolgov <9erthalion6@gmail.com>) |
Список | pgsql-hackers |
Thank you, pushed with some editorization Dmitry Dolgov wrote: >> On 7 April 2018 at 17:09, Teodor Sigaev <teodor@sigaev.ru> wrote: >>>> See workable sketch for parsing jsonb flags and new worker variant. >>> >>> >>> Yep, thanks for the sketch. Here is the new version of patch, does it look >>> close to what you have in mind? >> >> >> Patch looks good except error messaging, you took it directly from sketch >> where I didn't spend time for it. Please, improve. elog() should be used >> only for impossible error, whereas user input could contins mistakes. > > I assume what you mean is that for user input errors we need to use ereport. > Indeed, thanks for noticing. I've replaced all elog except the last one, since > it actually describes an impossible situation, when we started to read an > array, but ended up having something else instead WJB_END_ARRAY. > -- Teodor Sigaev E-mail: teodor@sigaev.ru WWW: http://www.sigaev.ru/
В списке pgsql-hackers по дате отправления: