Re: Regression in statement locations

Поиск
Список
Период
Сортировка
От David Steele
Тема Re: Regression in statement locations
Дата
Msg-id 0546d531-50eb-4ffc-b046-987cae4ab4f6@pgbackrest.org
обсуждение исходный текст
Ответ на Re: Regression in statement locations  (Sami Imseih <samimseih@gmail.com>)
Список pgsql-hackers
On 5/20/25 07:34, Sami Imseih wrote:
> Tested the patch and it looks good to me.
> 
> Not that I thought it would fail, but I also confirmed the pgaudit case
> works as expected.

I also tested and everything looks good with the patch.

I did a careful examination of the remaining diffs (there are quite a 
few) and in every case I consider them to be beneficial, i.e. they make 
the output more targeted and readable.

I did not do a real code review, but I did notice that the test table 
column is called weird_name as in our tests. I would argue that since it 
is missing the quotes and space it is not really all that weird and 
should maybe get a normal name so developers in the future don't wonder 
what is weird about it.

Thank you for this improvement and the quick fix!

Regards,
-David



В списке pgsql-hackers по дате отправления: