Hello,
Since 14e8803f1, it's not necessary to acquire the SyncRepLock to see up
to date data. But it looks like this commit didn't update all the
comment around MyProc->syncRepState, which still mention retrieving the
value without and without lock. Also, there's I think a now unneeded
test to try to retrieve again syncRepState.
Patch attached to fix both small issues, present since 9.5.
--
Julien Rouhaud
http://dalibo.com - http://dalibo.org