Re: Bug in canonicalize_path()

----- Original Message ----- 
From: "Tom Lane" <tgl@sss.pgh.pa.us>
To: "Bruce Momjian" <pgman@candle.pha.pa.us>
Cc: "William ZHANG" <uniware@zedware.org>; <pgsql-patches@postgresql.org>
Sent: Friday, August 12, 2005 10:31 AM
Subject: Re: [PATCHES] Bug in canonicalize_path() 


> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Yep, it is a bug on 8.0.X.  Are you suggesting a backpatch?  We can do
> > it.  Any objections?
> 
> I think he's suggesting that we depend on GetFullPathName(), which seems
> a bit pointless considering we have to write the code anyway for other
> platforms.
 
  If it must be fixed, I think we can learn sth. from GetFullPathName().
  Since we can not rely on this function on other platforms, we should
write it from scratch.

> I didn't much like the patch as-is; we should think a little harder
> about fixing the logic properly.
> 
> regards, tom lane