Re: Switching timeline over streaming replication

On Tuesday, October 09, 2012 10:32 PM Heikki Linnakangas wrote:
> On 06.10.2012 15:58, Amit Kapila wrote:
> > One more test seems to be failed. Apart from this, other tests are
> passed.
> >
It seems there is one more defect, please check the same
Defect: 
       1. start primary A        2. start standby B following A        3. start cascade standby C following B.
4.Promote standby B.        5. After successful time line switch in cascade standby C, stop C.        6. Restart C,
startupis failing with the following error.        FATAL:  requested timeline 2 does not contain minimum recovery
point
0/3000000 on timeline 1 


Review: 
The following statement is present in the hig-availability.sgml file, which
is also needs to be modified in the patch. 

Promoting a cascading standby terminates the immediate downstream
replication connections which it serves. This is because the timeline
becomes different between standbys, and they can no longer continue
replication. The affected standby(s) may reconnect to reestablish streaming
replication.


I felt some of minor comments are still not handled:
35. +SendTimeLineHistory(TimeLineHistoryCmd *cmd)  {  .. + fd = PathNameOpenFile(path, O_RDONLY | PG_BINARY, 0666);
errorhandling for fd < 0 is missing.  
 
36.+SendTimeLineHistory(TimeLineHistoryCmd *cmd)  {  .. if (nread <= 0) 
+                        ereport(ERROR, 
+                                        (errcode_for_file_access(), 
+                                         errmsg("could not read file
\"%s\": %m", 
+                                                        path)));

FileClose should be done in error case as well.


With Regards,
Amit Kapila.