Re: postgres_fdw batching vs. (re)creating the tuple slots
| От | Tomas Vondra |
|---|---|
| Тема | Re: postgres_fdw batching vs. (re)creating the tuple slots |
| Дата | |
| Msg-id | 0079c3ee-4645-2cab-50a1-50d0d7152b66@enterprisedb.com обсуждение исходный текст |
| Ответ на | Re: postgres_fdw batching vs. (re)creating the tuple slots (Tomas Vondra <tomas.vondra@enterprisedb.com>) |
| Список | pgsql-hackers |
On 6/16/21 4:23 PM, Tomas Vondra wrote: > On 6/16/21 2:36 PM, Alexander Pyhalov wrote: >> >> Hi. >> It seems this commit >> >> commit b676ac443b6a83558d4701b2dd9491c0b37e17c4 >> Author: Tomas Vondra <tomas.vondra@postgresql.org> >> Date: Fri Jun 11 20:19:48 2021 +0200 >> >> Optimize creation of slots for FDW bulk inserts >> >> has broken batch insert for partitions with unique indexes. >> > > Thanks for the report and reproducer! > > Turns out this is a mind-bogglingly silly bug I made in b676ac443b :-( > The data is copied into the slots only in the branch that initializes > them, so the subsequent batches just insert the same data over and over. > > The attached patch fixes that, and adds a regression test (a bit smaller > version of your reproducer). I'll get this committed shortly. > Pushed, after a bit more cleanup and testing. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
В списке pgsql-hackers по дате отправления: