Re: win32mak_patch

Hi.

Eh? It is strange...
http://winpg.jp/~saito/pg_work/WIN32_BUILD_INF/psql_win32.mak
Actually, it is required although psql is built. Have I missed something?

Regards,
Hiroshi Saito

----- Original Message -----
From: "Magnus Hagander" <magnus@hagander.net>


> The changes except the one to exports.txt look ok.
>
> Why do you need to export pgwin32_safestat? It's *not* exported when
> you build with mingw or the automated msvc build, and nothing breaks
> there. Who is trying to use it?
>
> //Magnus
>
> Hiroshi Saito wrote:
>> Hi.
>>
>> Oops, Certainly.
>> I propose the method of merging by distprep as exports.txt.win32.
>> What do you think?
>>
>> Regards,
>> Hiroshi Saito
>>
>> ----- Original Message -----
>> From: "Tom Lane" <tgl@sss.pgh.pa.us>
>>
>>
>> > "Hiroshi Saito" <z-saito@guitar.ocn.ne.jp> writes:
>> >> *** src/interfaces/libpq/exports.txt.orig Sun Apr 27 23:41:51 2008
>> >> --- src/interfaces/libpq/exports.txt Sun Apr 27 23:42:48 2008
>> >> ***************
>> >> *** 141,143 ****
>> >> --- 141,144 ----
>> >>   pg_valid_server_encoding_id 139
>> >>   PQconnectionNeedsPassword 140
>> >>   lo_import_with_oid   141
>> >> + pgwin32_safestat          142
>> >
>> >
>> > We are most certainly NOT doing that (for one reason, it will
>> > instantly break every platform except Windows).  If there is
>> > something that seems to require it then you need to find another
>> > way.
>> >
>> > regards, tom lane
>>
>> --
>> Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgsql-patches
>
>
> --
> Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-patches