Re: Rename of triggers for partitioned tables
| От | Arne Roland |
|---|---|
| Тема | Re: Rename of triggers for partitioned tables |
| Дата | |
| Msg-id | 004683a28e714bf3beb9a413a2ffbcb9@index.de обсуждение исходный текст |
| Ответ на | Re: Rename of triggers for partitioned tables (Alvaro Herrera <alvherre@alvh.no-ip.org>) |
| Ответы |
Re: Rename of triggers for partitioned tables
Re: Rename of triggers for partitioned tables |
| Список | pgsql-hackers |
Hi!
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
Sent: Tuesday, July 20, 2021 02:03
To: Arne Roland
Cc: vignesh C; Zhihong Yu; Pg Hackers
Subject: Re: Rename of triggers for partitioned tables
To: Arne Roland
Cc: vignesh C; Zhihong Yu; Pg Hackers
Subject: Re: Rename of triggers for partitioned tables
I found this coding too convoluted, so I rewrote it in a different way.
You tests pass with this, but I admit I haven't double-checked them yet;
I'll do that next.
You tests pass with this, but I admit I haven't double-checked them yet;
I'll do that next.
Is your patch based on master? It doesn't apply at my end.
I don't think we need to give a NOTICE when the trigger name does not
match; it doesn't really matter that the trigger was named differently
before the command, does it?
I don't think we need to give a NOTICE when the trigger name does not
match; it doesn't really matter that the trigger was named differently
before the command, does it?
I'd expect the command
ALTER TRIGGER name ON table_name RENAME TO new_name;
to rename a trigger named "name". We are referring the trigger via it's name after all. If a child is named differently we break with that assumption. I think informing the user about that, is very valuable.
ALTER TRIGGER name ON table_name RENAME TO new_name;
to rename a trigger named "name". We are referring the trigger via it's name after all. If a child is named differently we break with that assumption. I think informing the user about that, is very valuable.
Regards
Arne
В списке pgsql-hackers по дате отправления: