RE: Typo: llvm*.cpp files identified as llvm*.c
От | Moon, Insung |
---|---|
Тема | RE: Typo: llvm*.cpp files identified as llvm*.c |
Дата | |
Msg-id | 002b01d4b2b8$fc2de5e0$f489b1a0$@lab.ntt.co.jp обсуждение исходный текст |
Ответ на | Re: Typo: llvm*.cpp files identified as llvm*.c (Thomas Munro <thomas.munro@enterprisedb.com>) |
Список | pgsql-hackers |
Dear Hackers. > -----Original Message----- > From: Thomas Munro [mailto:thomas.munro@enterprisedb.com] > Sent: Wednesday, January 23, 2019 9:38 AM > To: Amit Langote > Cc: Andres Freund; Pg Hackers > Subject: Re: Typo: llvm*.cpp files identified as llvm*.c > > On Wed, Jan 23, 2019 at 1:16 PM Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote: > > On 2019/01/23 4:51, Andres Freund wrote: > > > On 2019-01-22 13:43:32 +0900, Amit Langote wrote: > > >> Attached find a patch to fix $subject. > > > > > > Thanks, pushed to master and 11. > > > > Thank you. > > It's not only the ending that's wrong. Here are some more source files whose IDENTIFICATION heading doesn't exactly match > their path: I found the same problem as you while checking the typo patch. So I attached a patch that modified the correct file path in IDENTIFICATION. Regards. Moon. > > $ git grep -A 1 IDENTIFICATION | grep -v IDENTIFICATION | grep -v -- > -- | sed 's/-[^a-z][^a-z]*/ /' | awk '{ if ($1 != $2) print; }' > doc/src/sgml/lobj.sgml src/test/examples/testlo.c src/backend/catalog/pg_publication.c pg_publication.c > src/backend/commands/publicationcmds.c publicationcmds.c src/backend/commands/subscriptioncmds.c subscriptioncmds.c > src/backend/jit/llvm/llvmjit_inline.cpp > src/backend/lib/llvmjit/llvmjit_inline.cpp > src/backend/jit/llvm/llvmjit_wrap.cpp src/backend/lib/llvm/llvmjit_wrap.cpp > src/backend/optimizer/util/appendinfo.c src/backend/optimizer/path/appendinfo.c > src/backend/optimizer/util/inherit.c src/backend/optimizer/path/inherit.c > src/backend/replication/logical/logicalfuncs.c > src/backend/replication/logicalfuncs.c > src/backend/replication/logical/reorderbuffer.c > src/backend/replication/reorderbuffer.c > src/backend/replication/logical/snapbuild.c src/backend/replication/snapbuild.c > src/backend/replication/pgoutput/Makefile src/backend/replication/pgoutput src/backend/utils/adt/version.c > src/include/replication/pgoutput.h pgoutput.h > > This could be really confusing for erm, future people reading a dot matrix print-out of the source code? > > -- > Thomas Munro > http://www.enterprisedb.com
Вложения
В списке pgsql-hackers по дате отправления: