This does look good,
I personally prefer more whitespace
After ( and , as well as moving the opening brace to the next line.
Public int foo(int x,int y){
x=y;
}
Turns into
Public int foo( int x, int y )
{
x = y;
}
I find this easier to read.
Comments?
Dave
-----Original Message-----
From: pgsql-jdbc-owner@postgresql.org
[mailto:pgsql-jdbc-owner@postgresql.org] On Behalf Of Bruce Momjian
Sent: September 4, 2001 3:26 PM
To: Liam Stewart
Cc: pgsql-jdbc@postgresql.org
Subject: Re: [JDBC] driver source code indentation
>
> I suggest that the JDBC driver adopt PostgreSQL's indentation
> standards
> (see PostgreSQL developers FAQ, question 1). I see that some source
> files have used this standard, but the vast majority do not. We should
> have a standard for consistency and our own sanity if nothing else.
Glad someone brought this up. A while ago I wrote:
I tried pgindent but it doesn't understand Java and made a mess
of it.
I used astyle with the options:
$ astyle --style=java -j *.java
I have the reformatted jdbc files at:
ftp://candle.pha.pa.us/pub/postgresql/astyle_jdbc.tar.gz
I must say it looks very good.
Can people tak a look at that and see if they like it? I will work on
astyle to find a format that matches the main code indenting.
If you like it, I will indent just after we go beta.
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania
19026
---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly