On 1/5/21 10:51 AM, Zhihong Yu wrote:
>
> + int lastExprLenght = 0;
>
> Did you mean to name the variable lastExprLenghth ?
>
> w.r.t. extracting to helper method, the second and third
> if (currentExprIdx == pgss_merge_threshold - 1) blocks are similar.
> It is up to you whether to create the helper method.
> I am fine with the current formation.
Dmitry, thoughts on this review?
Regards,
--
-David
david@pgmasters.net