Re: GUC for temporarily disabling event triggers

Поиск
Список
Период
Сортировка
Искать
От
Michael Paquier
Тема
Re: GUC for temporarily disabling event triggers
Дата
Msg-id
ZC0s+BRMqRupDInQ@paquier.xyz
Ответ на
Список
Дерево обсуждения
GUC for temporarily disabling event triggers Daniel Gustafsson <daniel@yesql.se>
Re: GUC for temporarily disabling event triggers Daniel Gustafsson <daniel@yesql.se>
Re: GUC for temporarily disabling event triggers vignesh C <vignesh21@gmail.com>
Re: GUC for temporarily disabling event triggers Daniel Gustafsson <daniel@yesql.se>
Re: GUC for temporarily disabling event triggers Ted Yu <yuzhihong@gmail.com>
Re: GUC for temporarily disabling event triggers Mikhail Gribkov <youzhick@gmail.com>
Re: GUC for temporarily disabling event triggers Daniel Gustafsson <daniel@yesql.se>
Re: GUC for temporarily disabling event triggers Mikhail Gribkov <youzhick@gmail.com>
Re: GUC for temporarily disabling event triggers Daniel Gustafsson <daniel@yesql.se>
Re: GUC for temporarily disabling event triggers Justin Pryzby <pryzby@telsasoft.com>
Re: GUC for temporarily disabling event triggers Daniel Gustafsson <daniel@yesql.se>
Re: GUC for temporarily disabling event triggers Robert Haas <robertmhaas@gmail.com>
Re: GUC for temporarily disabling event triggers Daniel Gustafsson <daniel@yesql.se>
Re: GUC for temporarily disabling event triggers Robert Haas <robertmhaas@gmail.com>
Re: GUC for temporarily disabling event triggers Daniel Gustafsson <daniel@yesql.se>
Re: GUC for temporarily disabling event triggers Michael Paquier <michael@paquier.xyz>
Re: GUC for temporarily disabling event triggers Daniel Gustafsson <daniel@yesql.se>
Re: GUC for temporarily disabling event triggers Robert Haas <robertmhaas@gmail.com>
Re: GUC for temporarily disabling event triggers Tom Lane <tgl@sss.pgh.pa.us>
Re: GUC for temporarily disabling event triggers Michael Paquier <michael@paquier.xyz>
Re: GUC for temporarily disabling event triggers Daniel Gustafsson <daniel@yesql.se>
Re: GUC for temporarily disabling event triggers Robert Haas <robertmhaas@gmail.com>
Re: GUC for temporarily disabling event triggers Daniel Gustafsson <daniel@yesql.se>
Re: GUC for temporarily disabling event triggers Robert Haas <robertmhaas@gmail.com>
Re: GUC for temporarily disabling event triggers Daniel Gustafsson <daniel@yesql.se>
Re: GUC for temporarily disabling event triggers Michael Paquier <michael@paquier.xyz>
Re: GUC for temporarily disabling event triggers Robert Haas <robertmhaas@gmail.com>
Re: GUC for temporarily disabling event triggers Daniel Gustafsson <daniel@yesql.se>
Re: GUC for temporarily disabling event triggers Michael Paquier <michael@paquier.xyz>
Re: GUC for temporarily disabling event triggers Daniel Gustafsson <daniel@yesql.se>
Re: GUC for temporarily disabling event triggers Michael Paquier <michael@paquier.xyz>
Re: GUC for temporarily disabling event triggers Daniel Gustafsson <daniel@yesql.se>
Re: GUC for temporarily disabling event triggers Daniel Gustafsson <daniel@yesql.se>
Re: GUC for temporarily disabling event triggers Daniel Gustafsson <daniel@yesql.se>
On Mon, Apr 03, 2023 at 11:35:14PM +0200, Daniel Gustafsson wrote:
> Yeah.  The patch as it stands allow for disabling specific types rather than
> all-or-nothing, which is why the name was "ignore".

FWIW, I agree with Robert's points here:
- disable_event_triggers or ignore_event_triggers = off leads to a
double-negative meaning, which is a positive.  Depending on one's
native language that can be confusing.
- Being able to write a list of event triggers working would be much
more interesting than just individual elements.
- There may be an argument for negated patterns?  Say,
a "!sql_drop,!ddl_command_start" would cause sql_drop and
ddl_command_start to be disabled with all the others enabled, and one
should not ne able to mix negated and non-negated patterns.

A few days before the end of the commit fest, perhaps you'd better
head towards having only an event_trigger = on | off or all | none and
consider expanding that later on?  From what I get at the top of the
thread, this would satisfy the main use case you seemed to worry
about to begin with.
--
Michael
В списке pgsql-hackers по дате отправления
От: Drouvot, Bertrand
Дата:
От: Masahiko Sawada
Дата:
FAQ