Re: Missing program_XXX calling in pgbench tests

On 2025/06/05 16:44, Hayato Kuroda (Fujitsu) wrote:
> Dear Peter,
> 
> Thanks for the comment.
> 
>> Patch 0001 looks very sensible.
>>
>> I don't think we need to bother we the other ones.  pg_config works
>> differently than the other programs anyway, because --version does not
>> exit the program.  And pg_bsd_indent is an externally maintained
>> program.  So I think it is ok if these two are intentionally different.
> 
> You meant that 0002-0004 are not needed, right?
> So let's put on out-of-scope...

I agree with Peter. I don't think patches 0002 and 0003 are necessary.

As for 0004, it adds tests for the short options -? and -V, which
duplicate the existing tests for the long options --help and --version.
I'm not sure it's worth adding tests just to confirm that the short
and long options behave the same.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation