Re: Postgres Windows build system doesn't work with pythoninstalled in Program Files
От
Victor Wagner
Тема
Re: Postgres Windows build system doesn't work with pythoninstalled in Program Files
Дата
Msg-id
20200501124817.0f253187@antares.wagner.home
Ответ на
Re: Postgres Windows build system doesn't work with python installedin Program Files (Michael Paquier)
Список
Дерево обсуждения
Postgres Windows build system doesn't work with python installed inProgram Files Victor Wagner <vitus@wagner.pp.ru>
Re: Postgres Windows build system doesn't work with python installedin Program Files Michael Paquier <michael@paquier.xyz>
Re: Postgres Windows build system doesn't work with pythoninstalled in Program Files Victor Wagner <vitus@wagner.pp.ru>
Re: Postgres Windows build system doesn't work with python installedin Program Files Michael Paquier <michael@paquier.xyz>
Re: Postgres Windows build system doesn't work with pythoninstalled in Program Files Victor Wagner <vitus@wagner.pp.ru>
Re: Postgres Windows build system doesn't work with python installedin Program Files Michael Paquier <michael@paquier.xyz>
Re: Postgres Windows build system doesn't work with python installedin Program Files Ranier Vilela <ranier.vf@gmail.com>
Re: Postgres Windows build system doesn't work with pythoninstalled in Program Files Victor Wagner <vitus@wagner.pp.ru>
Re: Postgres Windows build system doesn't work with python installedin Program Files Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Re: Postgres Windows build system doesn't work with python installedin Program Files Michael Paquier <michael@paquier.xyz>
Re: Postgres Windows build system doesn't work with python installedin Program Files Ranier Vilela <ranier.vf@gmail.com>
Re: Postgres Windows build system doesn't work with python installedin Program Files Ranier Vilela <ranier.vf@gmail.com>
Re: Postgres Windows build system doesn't work with python installedin Program Files Ranier Vilela <ranier.vf@gmail.com>
Re: Postgres Windows build system doesn't work with python installedin Program Files Michael Paquier <michael@paquier.xyz>
Re: Postgres Windows build system doesn't work with pythoninstalled in Program Files Victor Wagner <vitus@wagner.pp.ru>
Re: Postgres Windows build system doesn't work with python installedin Program Files Ranier Vilela <ranier.vf@gmail.com>
Re: Postgres Windows build system doesn't work with python installedin Program Files Ranier Vilela <ranier.vf@gmail.com>
Re: Postgres Windows build system doesn't work with pythoninstalled in Program Files Victor Wagner <vitus@wagner.pp.ru>
Re: Postgres Windows build system doesn't work with python installedin Program Files Ranier Vilela <ranier.vf@gmail.com>
Re: Postgres Windows build system doesn't work with python installedin Program Files Ranier Vilela <ranier.vf@gmail.com>
Re: Postgres Windows build system doesn't work with python installedin Program Files Ranier Vilela <ranier.vf@gmail.com>
Re: Postgres Windows build system doesn't work with python installedin Program Files Michael Paquier <michael@paquier.xyz>
Re: Postgres Windows build system doesn't work with python installedin Program Files Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Re: Postgres Windows build system doesn't work with python installedin Program Files Michael Paquier <michael@paquier.xyz>
Re: Postgres Windows build system doesn't work with python installedin Program Files Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Re: Postgres Windows build system doesn't work with python installedin Program Files Michael Paquier <michael@paquier.xyz>
Re: Postgres Windows build system doesn't work with python installedin Program Files Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Re: Postgres Windows build system doesn't work with python installedin Program Files Michael Paquier <michael@paquier.xyz>
Re: Postgres Windows build system doesn't work with python installedin Program Files David Zhang <david.zhang@highgo.ca>
Re: Postgres Windows build system doesn't work with python installed in Program Files Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Re: Postgres Windows build system doesn't work with python installed in Program Files Michael Paquier <michael@paquier.xyz>
Re: Postgres Windows build system doesn't work with python installedin Program Files Ranier Vilela <ranier.vf@gmail.com>
В Fri, 1 May 2020 17:52:15 +0900
Michael Paquier пишет:
> On Thu, Apr 30, 2020 at 03:06:08PM +0300, Victor Wagner wrote:
> > Fix is very simple, see attach.
> >
> > Patch is made against REL_12_STABLE, but probably applicable to
> > other versions as well.
>
> Indeed, thanks.
>
> > my $pythonprog = "import sys;print(sys.prefix);"
> > .
> > "print(str(sys.version_info[0])+str(sys.version_info[1]))"; my
> > $prefixcmd =
> > - $solution->{options}->{python} . "\\python -c
> > \"$pythonprog\"";
> > + '"' . $solution->{options}->{python} . "\\python\"
> > -c \"$pythonprog\""; my $pyout = `$prefixcmd`;
> > die "Could not query for python version!\n" if $?;
> > my ($pyprefix, $pyver) = split(/\r?\n/, $pyout);
>
> This reminds me of ad7595b. Wouldn't it be better to use qq() here?
Maybe. But probably original author of this code was afraid of using
too long chain of ->{} in the string substitution.
So, I left this style n place.
Nonetheless, using qq wouldn't save us from doubling backslashes.
--
В списке pgsql-hackers по дате отправления
От: Michael Paquier
Дата:
От: Atsushi Torikoshi
Дата: