Re: Inconsistent usage of BACKEND_* symbols
От
Michael Paquier
Тема
Re: Inconsistent usage of BACKEND_* symbols
Дата
Msg-id
20191002071715.GE3130@paquier.xyz
Ответ на
Inconsistent usage of BACKEND_* symbols (Kyotaro Horiguchi)
Список
Дерево обсуждения
Inconsistent usage of BACKEND_* symbols Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Re: Inconsistent usage of BACKEND_* symbols Michael Paquier <michael@paquier.xyz>
On Mon, Sep 30, 2019 at 04:39:59PM +0900, Kyotaro Horiguchi wrote:
> @@ -2740,8 +2740,8 @@ pmdie(SIGNAL_ARGS)
> {
> /* autovac workers are told to shut down immediately */
> /* and bgworkers too; does this need tweaking? */
> - SignalSomeChildren(SIGTERM,
> - BACKEND_TYPE_AUTOVAC | BACKEND_TYPE_BGWORKER);
> + SignalSomeChildren(SIGTERM, BACKEND_TYPE_WORKER);
> +
For this one the comment would be inconsistent with the flags listed.
> /* and the autovac launcher too */
> if (AutoVacPID != 0)
> signal_child(AutoVacPID, SIGTERM);
> @@ -2821,8 +2821,7 @@ pmdie(SIGNAL_ARGS)
> (errmsg("aborting any active transactions")));
> /* shut down all backends and workers */
> SignalSomeChildren(SIGTERM,
> - BACKEND_TYPE_NORMAL | BACKEND_TYPE_AUTOVAC |
> - BACKEND_TYPE_BGWORKER);
> + BACKEND_TYPE_NORMAL | BACKEND_TYPE_WORKER);
Okay for this one.
--
Michael
В списке pgsql-hackers по дате отправления