Re: Refactoring of compression options in pg_basebackup

On Tue, Jan 18, 2022 at 10:04:56AM -0500, Robert Haas wrote:
> I think it could make sense for you implement
> --compress=METHOD[:LEVEL], keeping -z and -Z N as synonyms for
> --compress=gzip and --compress=gzip:N, and with --compress=N being
> interpreted as --compress=gzip:N. Then I'll generalize that to
> --compress=[{client|server}-]METHOD[:LEVEL] on the other thread. I
> think we should leave it where, if you don't say either client or
> server, you get client, because that's the historical behavior.
> 
> If that doesn't work for you, please let me know what you would prefer.

WFM.  Attached is a patch that extends --compress to handle a method
with an optional compression level.  Some extra tests are added to
cover all that.

Thoughts?
--
Michael