Re: ALTER INDEX
От
Gavin Sherry
Тема
Re: ALTER INDEX
Дата
Msg-id
Pine.LNX.4.58.0408132134560.17689@linuxworld.com.au
Ответ на
Re: ALTER INDEX (Stefan Kaltenbrunner)
Список
Дерево обсуждения
ALTER INDEX Gavin Sherry <swm@linuxworld.com.au>
Re: ALTER INDEX Gavin Sherry <swm@linuxworld.com.au>
Re: ALTER INDEX Bruce Momjian <pgman@candle.pha.pa.us>
Re: ALTER INDEX "Marc G. Fournier" <scrappy@postgresql.org>
Re: ALTER INDEX Bruce Momjian <pgman@candle.pha.pa.us>
Re: ALTER INDEX Tom Lane <tgl@sss.pgh.pa.us>
Re: ALTER INDEX Gavin Sherry <swm@linuxworld.com.au>
Re: ALTER INDEX Bruce Momjian <pgman@candle.pha.pa.us>
Re: ALTER INDEX Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>
Re: ALTER INDEX Bruce Momjian <pgman@candle.pha.pa.us>
Re: ALTER INDEX Bruce Momjian <pgman@candle.pha.pa.us>
Re: ALTER INDEX Gavin Sherry <swm@linuxworld.com.au>
Oops.
Too much with the ol' cut and paste.
I'm happy to send an updated patch but perhaps the committer, assuming the
patch is accepted, would be kind enough to update for me.
Thanks for reviewing.
Gavin
On Fri, 13 Aug 2004, Stefan Kaltenbrunner wrote:
> Gavin Sherry wrote:
>
>
> > Index: src/bin/psql/tab-complete.c
> > ===================================================================
> > RCS file: /usr/local/cvsroot/pgsql-server/src/bin/psql/tab-complete.c,v
> > retrieving revision 1.109
> > diff -2 -c -r1.109 tab-complete.c
> > *** src/bin/psql/tab-complete.c 28 Jul 2004 14:23:30 -0000 1.109
> > --- src/bin/psql/tab-complete.c 13 Aug 2004 06:34:55 -0000
> > ***************
> > *** 633,637 ****
> > {
> > static const char *const list_ALTER[] =
> > ! {"DATABASE", "GROUP", "SCHEMA", "TABLE", "TRIGGER", "USER", NULL};
> >
> > COMPLETE_WITH_LIST(list_ALTER);
> > --- 633,638 ----
> > {
> > static const char *const list_ALTER[] =
> > ! {"DATABASE", "GROUP", "SCHEMA", "TABLE", "TRIGGER", "USER", "INDEX",
> > ! NULL};
> >
> > COMPLETE_WITH_LIST(list_ALTER);
> > ***************
> > *** 647,650 ****
> > --- 648,661 ----
> > COMPLETE_WITH_LIST(list_ALTERDATABASE);
> > }
> > + /* ALTER INDEX */
> > + else if (pg_strcasecmp(prev3_wd, "ALTER") == 0 &&
> > + pg_strcasecmp(prev2_wd, "INDEX") == 0)
> > + {
> > + static const char *const list_ALTERDATABASE[] =
> > + {"SET TABLESPACE", "OWNER TO", "RENAME TO", NULL};
> > +
> > + COMPLETE_WITH_LIST(list_ALTERDATABASE);
>
> minor issue/nit(?): reusing list_ALTERDATABASE for the ALTER INDEX part
> looks a little strange ...
>
>
> Stefan(who could really need some feedback on his own tab-complete patch
> *g*)
>
>
> !DSPAM:411c802d169118747610806!
>
>
В списке pgsql-patches по дате отправления
От: Andrew Dunstan
Дата: