pgsql: Fix another join removal bug: the check on PlaceHolderVars was w

Fix another join removal bug: the check on PlaceHolderVars was wrong.

The previous coding would decide that join removal was unsafe upon finding
a PlaceHolderVar that needed to be evaluated at the inner rel and then used
above the join.  However, this fails to cover the case of PlaceHolderVars
that refer to both the inner rel and some other rels.  Per bug report from
Andrus.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=c8c03d72e10cab3cc47975b2689c8efbb4eade94

Modified Files
--------------
src/backend/optimizer/plan/analyzejoins.c |   18 +++++++++++++-----
src/test/regress/expected/join.out        |   21 +++++++++++++++++++++
src/test/regress/sql/join.sql             |   15 +++++++++++++++
3 files changed, 49 insertions(+), 5 deletions(-)