Re: Are we missing (void) when return value of fsm_set_and_search is ignored?

Поиск
Список
Период
Сортировка
Искать
От
Bharath Rupireddy
Тема
Re: Are we missing (void) when return value of fsm_set_and_search is ignored?
Дата
Msg-id
CALj2ACWn8WNtvuOOuJD95fe1G+pSHfX+Fi8Sa_ai=QZoBEoOgA@mail.gmail.com
Ответ на
Список
Дерево обсуждения
Are we missing (void) when return value of fsm_set_and_search is ignored? Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Are we missing (void) when return value of fsm_set_and_search is ignored? Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Re: Are we missing (void) when return value of fsm_set_and_search is ignored? Julien Rouhaud <rjuju123@gmail.com>
Re: Are we missing (void) when return value of fsm_set_and_search is ignored? Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Re: Are we missing (void) when return value of fsm_set_and_search is ignored? Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Are we missing (void) when return value of fsm_set_and_search is ignored? Julien Rouhaud <rjuju123@gmail.com>
Re: Are we missing (void) when return value of fsm_set_and_search is ignored? Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Are we missing (void) when return value of fsm_set_and_search is ignored? Dilip Kumar <dilipbalaut@gmail.com>
Re: Are we missing (void) when return value of fsm_set_and_search is ignored? Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Are we missing (void) when return value of fsm_set_and_search is ignored? Dilip Kumar <dilipbalaut@gmail.com>
Re: Are we missing (void) when return value of fsm_set_and_search is ignored? Julien Rouhaud <rjuju123@gmail.com>
Re: Are we missing (void) when return value of fsm_set_and_search is ignored? Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
On Thu, Jun 3, 2021 at 5:22 PM Julien Rouhaud  wrote:
>
> On Thu, Jun 3, 2021 at 6:54 PM Bharath Rupireddy
>  wrote:
> >
> > It looks like for some of the fsm_set_and_search calls whose return
> > value is ignored (in fsm_search and RecordPageWithFreeSpace), there's
> > no (void). Is it intentional? In the code base, we generally have
> > (void) when non-void return value of a function is ignored.
>
> That's a good practice, +1 for changing that.

Thanks. PSA v1 patch.

With Regards,
Bharath Rupireddy.
В списке pgsql-hackers по дате отправления
От: Kyotaro Horiguchi
Дата:
Сообщение: Re: Duplicate history file?
От: Peter Eisentraut
Дата:
FAQ