Re: pgsql: Remove useless default clause in switch
От
David Rowley
Тема
Re: pgsql: Remove useless default clause in switch
Дата
Msg-id
CAKJS1f9xM4dwZDaTEwcFgOsGx-fOkOoD-7xgNxCxGC5dyN9u=g@mail.gmail.com
Ответ на
Re: pgsql: Remove useless default clause in switch (Alvaro Herrera)
Список
Дерево обсуждения
pgsql: Remove useless default clause in switch Alvaro Herrera <alvherre@alvh.no-ip.org>
Re: pgsql: Remove useless default clause in switch David Rowley <david.rowley@2ndquadrant.com>
Re: pgsql: Remove useless default clause in switch Michael Paquier <michael@paquier.xyz>
Re: pgsql: Remove useless default clause in switch Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Re: pgsql: Remove useless default clause in switch Alvaro Herrera <alvherre@alvh.no-ip.org>
Re: pgsql: Remove useless default clause in switch David Rowley <david.rowley@2ndquadrant.com>
Re: pgsql: Remove useless default clause in switch Andrew Gierth <andrew@tao11.riddles.org.uk>
Re: pgsql: Remove useless default clause in switch Tom Lane <tgl@sss.pgh.pa.us>
On 24 April 2018 at 13:50, Alvaro Herrera wrote: > David Rowley wrote: >> On 24 April 2018 at 03:12, Alvaro Herrera wrote: >> > Remove useless default clause in switch >> > >> > The switch covers all values of the enum driver variable, so having a >> > default: clause is useless, even if it's only to do Assert(false). >> >> Just for my own understanding: >> >> I always thought that when all options were covered that we generally >> kept a default just in case someone added another enum and forgot to >> update the code. > > The compiler will emit a warning when it sees that not all cases are > handled, so it's not necessary to have a default case. Thank you all for explaining that. It very much makes sense now. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
В списке pgsql-committers по дате отправления
От: Alvaro Herrera
Дата: